Remove PHPStan from pre-commit hook #7618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If we accept this, why don't we go with |
michalsn
approved these changes
Jun 26, 2023
lonnieezell
force-pushed
the
remove-precommit-hook
branch
from
6dab47e to
bd3420b
Compare
|
Rebased onto develop branch. |
samsonasik
approved these changes
Jun 27, 2023
kenjis
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes PHPstan from our precommit hook. While that was well intentioned, I believe from discussions we've had that most of the team actually finds that more trouble than it is worth. I believe it causes a choke point for potential contributors who get stuck trying to pass that and never actually submit anywhere. With it gone, they can submit and open up a discussions about the code much easier.
At one point discussions mentioned removing the entire pre-commit hook, but I find value in the linting and auto-fixing of style issues where it can, and believe that stan was the biggest pain point in the process.