Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [Auto Routing Improved] feature testing may use incorrect param count #7597

Merged

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jun 19, 2023

Description
Follow-up #7543
See https://forum.codeigniter.com/showthread.php?tid=87818&pid=410558#pid410558

  • fix a bug that $this->params is not reset for a new HTTP request

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

kenjis added 2 commits June 19, 2023 17:08
A previous test result causes an params count error in HTTP testing.
@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Jun 19, 2023
@kenjis kenjis changed the title fix: [Auto Routing Improved] feature testing may uses incorrect param count fix: [Auto Routing Improved] feature testing may use incorrect param count Jun 19, 2023
@kenjis
Copy link
Member Author

kenjis commented Jun 29, 2023

Can someone please review this?

@kenjis kenjis merged commit 93006e3 into codeigniter4:develop Jun 30, 2023
@kenjis kenjis deleted the fix-AutoRouterImproved-params-not-reset branch June 30, 2023 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants