Add debug views hints #759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lonnieezell
requested changes
Oct 8, 2017
system/View/View.php
Outdated
| // Compare Environment or some DebugBar Config? | ||
| if (ENVIRONMENT == 'development') | ||
| { | ||
| $output = '<div class="debug-view"><div class="debug-view-path">' . $file . '</div>' |
There was a problem hiding this comment.
This should have an inline style set to display: none so that in case someone is in debug mode and has the Toolbar filter turned off, these don't get displayed.
application/Controllers/Checks.php
Outdated
| @@ -306,4 +306,9 @@ public function parser() | |||
| $this->parser = Services::parser(); | |||
| } | |||
|
|
|||
| public function blocks() | |||
There was a problem hiding this comment.
The Checks controller is not something that is going to survive long and should not be the sole method of testing.
application/Views/blocks/a.php
Outdated
| @@ -0,0 +1,14 @@ | |||
| <div class="block a"> | |||
There was a problem hiding this comment.
Please remove theses 'blocks' views. I realize they were used while you were testing, but they're not something we want to ship with the framework.
lonnieezell
approved these changes
Oct 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#758