perf: Change current directory in public/index.php only if necessary

[bebehr]

Description
Checked if current directory is pointing to the front controller's directory.
Only change the directory if they differ because chdir call is not necessary and is not performant.

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[kenjis]

Thank you for sending this PR.

First of all, you must sign all your commits.
See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#signing

[kenjis]

The chdir() came from: #36 and #5972

[kenjis]

Only change the directory if they differ because chdir call is not necessary and is not performant.

Can you show the benchmarks?

[bebehr]

Running on Windows 11 with XAMPP
Loop 100000 times:

chdir(FCPATH);
4.0267419815063 seconds

if (getcwd() . DIRECTORY_SEPARATOR !== FCPATH) {}
0.030242919921875 seconds

Assuming the default case is: the workdir is already correct and does not have to be changed

[bebehr]

Thank you for sending this PR.

First of all, you must sign all your commits. See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#signing

Done

[bebehr]

Only change the directory if they differ because chdir call is not necessary and is not performant.

Can you show the benchmarks?

#7559 (comment)

[kenjis]

Thanks.

But see https://github.com/codeigniter4/CodeIgniter4/pull/7559/commits
The first commit is not signed.

And we don't use git merge in PR branches.
Can you rebase?
See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#updating-your-branch

If you set up git to sign automatically, git rebase will sign your all commits.

[kenjis]

See https://github.com/codeigniter4/CodeIgniter4/pull/7559/commits
You are merging again and again.

As I said, we do not use git merge, but use git rebase.

[bebehr]

See https://github.com/codeigniter4/CodeIgniter4/pull/7559/commits You are merging again and again.

As I said, we do not use git merge, but use git rebase.

Thanks! Sorry, signing and rebase was completely new to me... I think I got it right now.

[kenjis]

On macOS.

chdir(FCPATH);
1.7629029750824 seconds

if (getcwd() . DIRECTORY_SEPARATOR !== FCPATH) {}
1.63840508461 seconds

$s = microtime(true);
for ($i = 0; $i <100000; $i++) {
    // Ensure the current directory is pointing to the front controller's directory
    if (getcwd() . DIRECTORY_SEPARATOR !== FCPATH) {
        chdir(FCPATH);
    }
}
echo microtime(true) - $s;
exit;

[kenjis]

@BennyBPB Thank you for rebasing!

There are three commits but it seems okay with one commit.
If you can squash the commits, do it.

[kenjis]

Remove the license comment.

[bebehr]

Remove the license comment.

Done, file comment is removed.

[bebehr]

@BennyBPB Thank you for rebasing!

There are three commits but it seems okay with one commit. If you can squash the commits, do it.

Removing the file comment was commit no 4.
I squished them into 1 commit now.

[kenjis]

@BennyBPB Thank you for squishing!