Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [Entity] fix incorrect return value #7544

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jun 6, 2023

Description
Related #7542

 ------ ------------------------------------------------------------------------------------------------------------------------------------------ 
  Line   system/Entity/Entity.php                                                                                                                  
 ------ ------------------------------------------------------------------------------------------------------------------------------------------ 
  468    Method CodeIgniter\Entity\Entity::__set() with return type void returns $this(CodeIgniter\Entity\Entity) but should not return anything.  
 ------ ------------------------------------------------------------------------------------------------------------------------------------------ 

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added refactor Pull requests that refactor code 4.4 labels Jun 6, 2023
@samsonasik samsonasik merged commit 4e15b81 into codeigniter4:4.4 Jun 7, 2023
@samsonasik
Copy link
Member

Thank you @kenjis

@kenjis kenjis deleted the fix-Entity-return-4.4 branch June 7, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.4 refactor Pull requests that refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants