Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double // in url in URI Routing example (Using Named Routes) #7466

Merged
merged 2 commits into from
Apr 29, 2023

Conversation

gremirarunico
Copy link
Contributor

@gremirarunico gremirarunico commented Apr 28, 2023

This is a very stupid edit, just a typo in the url of example.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@datamweb
Copy link
Contributor

@gremirarunico gremirarunico force-pushed the develop branch 4 times, most recently from 98afb7f to 49ec26a Compare April 28, 2023 21:49
@gremirarunico
Copy link
Contributor Author

gremirarunico commented Apr 28, 2023

Done. I am sorry. This is the first time I sign a commit, I didn't think it was necessary.
EDIT: I think I messed up something. There was another commit I did some minutes later, but I didn't insert in the pull request because it was another (minor) error.

The error is in https://www.codeigniter.com/user_guide/incoming/routing.html#for-site-root-uri
The text refers to the controller app/Controllers/Home.php but in the example code the controller is app/Controllers/Welcome.php.
What do you want I do? I revoke the pull request and start again? We merge the two together?

@kenjis kenjis added the documentation Pull requests for documentation only label Apr 29, 2023
@kenjis
Copy link
Member

kenjis commented Apr 29, 2023

Please don't remove the checklist.

@kenjis
Copy link
Member

kenjis commented Apr 29, 2023

If you learn to use git, you can easily remove the commit for another issue.
But that is a minor fix on the docs, so I will merge this PR.

Please send one PR for one issue next time.

@kenjis kenjis merged commit 483674d into codeigniter4:develop Apr 29, 2023
@gremirarunico
Copy link
Contributor Author

If you learn to use git, you can easily remove the commit for another issue. But that is a minor fix on the docs, so I will merge this PR.

Thank you for your understanding. Programming is a hobby for me, so there are still some significant gaps in my knowledge of Git that I need to address. I promise to be more attentive next time. Have a great day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests for documentation only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants