-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: user guide dark mode #7463
feat: user guide dark mode #7463
Conversation
I think it looks great! There are a couple of things I could nit-pick about but are just personal preference and wouldn't really need to change, I don't think. Thanks! |
I'm open to making improvements if folks think they are needed. However, changes may take me some time. |
How can I test it? |
I use "auto mode". Ah, using Chrome, the page is in the dark mode. |
Judging by your browser's color, dark mode is not yet active (you probably need to wait a bit longer). Sorry I didn't notice your edit. |
Chrome and Safari shows dark mode page. |
Hmm... I will have to look into it. So auto-mode in the system doesn't enable dark mode on the page. I will check it out today. |
Thanks for figuring it out. Function/class reference styles have been updated. It was strange because it was displaying correctly on my local build. Anyway, thanks for letting me know. |
@michalsn I have a problem with the white |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@datamweb What's wrong with the border? |
No, I mean white color, I feel that this color is chosen too bright. |
It wasn't strictly white, but I darkened it more, so it should be ok now. Let me know. |
@michalsn thank you! nice. |
Description
This is an ancient work from December. It adds a dark mode to our user guide.
Since Read the Docs doesn't have built-in support for the dark mode style, I implemented a solution strictly dependent on system settings. So there is no switch to enable or disable dark mode.
Preview: https://michalsn.github.io/CodeIgniter4/ - please don't test it on a sunny day 😅
Checklist: