docs: fix PHPDoc types in Database Connection. #7433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenjis
reviewed
Apr 14, 2023
kenjis
reviewed
Apr 14, 2023
kenjis
reviewed
Apr 14, 2023
kenjis
reviewed
Apr 14, 2023
| @@ -98,7 +100,7 @@ public function getVersion(): string; | |||
| * Should automatically handle different connections for read/write | |||
| * queries if needed. | |||
| * | |||
| * @param mixed ...$binds | |||
| * @param array|string|null ...$binds | |||
There was a problem hiding this comment.
This seems a bug.
Suggested change
| * @param array|string|null ...$binds | |
| * @param array|string|null $binds |
There was a problem hiding this comment.
Is there anything need to be fixed besides removing ...?
There was a problem hiding this comment.
No, for now.
The difference of the parameter count may be a bug.
kenjis
reviewed
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #6310
Checklist: