Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: replace type mixed at Config class. #7432

Merged
merged 2 commits into from
Apr 19, 2023
Merged

docs: replace type mixed at Config class. #7432

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ba53c4
docs: replace type `mixed` at Config class.
ping-yee Apr 13, 2023
939debe
docs: Add the type of parameter.
ping-yee Apr 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions system/Config/BaseService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,9 +173,9 @@ class BaseService
*
* $key must be a name matching a service.
*
* @param mixed ...$params
* @param array|object|string|null ...$params
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are parameters for services. Maybe all except for resource?
Or resource might be passed by devs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have been added!

*
* @return mixed
* @return object
*/
protected static function getSharedInstance(string $key, ...$params)
{
Expand Down Expand Up @@ -239,7 +239,7 @@ public static function locator(bool $getShared = true)
* Provides the ability to perform case-insensitive calling of service
* names.
*
* @return mixed
* @return object|null
*/
public static function __callStatic(string $name, array $arguments)
{
Expand Down Expand Up @@ -296,7 +296,7 @@ public static function resetSingle(string $name)
/**
* Inject mock object for testing.
*
* @param mixed $mock
* @param object $mock
*/
public static function injectMock(string $name, $mock)
{
Expand All @@ -309,7 +309,7 @@ public static function injectMock(string $name, $mock)
* looks for the service method in each, returning an instance of
* the service, if available.
*
* @return mixed
* @return object|null
*
* @deprecated
*
Expand Down
2 changes: 1 addition & 1 deletion system/Config/Config.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ class Config
* @param string $name Configuration name
* @param bool $getShared Use shared instance
*
* @return mixed|null
* @return object|null
*/
public static function get(string $name, bool $getShared = true)
{
Expand Down