fix: spark routes shows invalid routes with Auto Routing Improved
#7417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenjis
added
the
bug
samsonasik
reviewed
Apr 9, 2023
Comment on lines
96
to
103
| // Skip the default controller. | ||
| if (class_basename($class) === $defaultController) { | ||
| continue; | ||
| } |
There was a problem hiding this comment.
just quick read, $class and $defaultControllerseems never replaced under loop, seems can be moved before loop to return early.
There was a problem hiding this comment.
Thank you for review. But it cannot be moved before loop.
The method is a bit difficult to understand.
I refactored and and some comments.
There was a problem hiding this comment.
@samsonasik I changed my mind. Please review #7419 when you have time.
kenjis
force-pushed
the
fix-spark-routes-auto-routing
branch
from
5a527d4 to
d5ac6b5
Compare
kenjis
force-pushed
the
fix-spark-routes-auto-routing
branch
from
d5ac6b5 to
a0578b3
Compare
To suppress Psalm error. ERROR: DuplicateArrayKey - system/Commands/Utilities/Routes/AutoRouterImproved/ControllerMethodReader.php:83:55 - String keys are not supported in unpacked arrays (see https://psalm.dev/151) $output = [...$output, ...$routeForDefaultController];
5 tasks
|
Go to #7419 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7415
spark routesshows the default controller's method routes that cannot be accessible.Checklist: