Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [Auto Routing Improved] Module Routing #7416

Merged
merged 6 commits into from
Apr 12, 2023
Merged

feat: [Auto Routing Improved] Module Routing #7416

merged 6 commits into from
Apr 12, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Apr 8, 2023 •
edited
Loading

Needs #7380

Description
Adds module routing.

E.g.,
app/Config/Routing.php:

public array $moduleRoutes = [
    'blog' => 'Acme\Blog\Controllers',
];

http://localhost:8080/blog/foo/bar will run Acme\Blog\Controllers\Foo::getBar().

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added enhancement PRs that improve existing functionalities 4.4 labels Apr 8, 2023
@kenjis kenjis marked this pull request as draft April 8, 2023 04:47
lonnieezell
lonnieezell approved these changes Apr 9, 2023
View reviewed changes
Copy link
Member

@lonnieezell lonnieezell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool idea! Nice addition.

@kenjis kenjis force-pushed the feat-auto-routing-module branch from af5ef91 to e1a1f89 Compare April 10, 2023 01:03
@kenjis kenjis marked this pull request as ready for review April 10, 2023 01:37
@kenjis
Copy link
Member Author

kenjis commented Apr 10, 2023

Added docs.

@kenjis kenjis merged commit c5b8676 into codeigniter4:4.4 Apr 12, 2023
@kenjis kenjis deleted the feat-auto-routing-module branch April 12, 2023 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

@lonnieezell lonnieezell lonnieezell approved these changes

Assignees
No one assigned
Labels
4.4 enhancement PRs that improve existing functionalities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @lonnieezell @michalsn