Feature/localization number filters #739
Conversation
| if (! isset($typeValues[$type])) | ||
| { | ||
| throw new \Exception('syntax error'); | ||
| //todo: raise mor appropriate /specific exception |
There was a problem hiding this comment.
Were you going to add more errors here?
system/View/NumberFilters.php
Outdated
| static $formatter, $currentStyle; | ||
|
|
||
| $locale = $locale ?? \CodeIgniter\Config\Services::request()->getLocale(); | ||
| log_message('info',\CodeIgniter\Config\Services::request()->getLocale()); |
There was a problem hiding this comment.
This looks like debug code. Please remove.
| { | ||
| $locale = $locale ?? \CodeIgniter\Config\Services::request()->getLocale(); | ||
|
|
||
| $formatter = self::getNumberFormatter($locale, 'currency'); |
| if (! isset($styleValues[$style])) | ||
| { | ||
| throw new \Exception('syntax error'); | ||
| //todo: raise more appropriate /specific exception |
There was a problem hiding this comment.
More specific exceptions needed?
| { | ||
| if (! class_exists('IntlDateFormatter')) | ||
| { | ||
| throw new \RuntimeException('The intl extension is needed to use intl-based filters.'); |
There was a problem hiding this comment.
This should be localized through the lang() function.
|
@lonnieezell I was waiting for your reply. Actually after writing this code I notice the format_number function of number helper which I think does the same thing (correct me if I wrong). So I wait before working further. |
|
Doh! You're right that |
|
@lonnieezell I would like to suggest that we should i) create a class i18n\number and use that class in number helper and localized filter. This way The NumberFIlters class I had created using twig extension can be used in both files . |
|
@jaynarayan89 I'm fine with that. |
|
@jaynarayan89 Were you going to make these changes you suggested? |
|
@lonnieezell yes I am working on it. Please give me two or three days. |
|
No worries - just checking in it this had been a few weeks. |
|
This was never updated. I'm working on a commit for these. |
Open for review