Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixes in retrieving error messages after redirect #7331

Closed
wants to merge 1 commit into from
Closed

fix: fixes in retrieving error messages after redirect #7331

wants to merge 1 commit into from

Conversation

ahmadinzero
Copy link

Description
this pull request for fix issue
7330
I fixed the getErrors() method in CodeIgniter/Validation/Validation.php so that it can retrieve error messages in the session

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@ahmadinzero ahmadinzero mentioned this pull request Mar 4, 2023
Closed
@kenjis
Copy link
Member

kenjis commented Mar 4, 2023

We do not accept this.
See #6380 (comment) and #6384

@kenjis kenjis closed this Mar 4, 2023
@kenjis
Copy link
Member

kenjis commented Mar 4, 2023

If you send a PR, please sign your commits.
See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#signing

@ahmadinzero
Copy link
Author

thanks for the advice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahmadinzero @kenjis