Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix $systemDirectory path in existing project. #7289

Merged
merged 1 commit into from
Feb 21, 2023

Conversation

jozefrebjak
Copy link
Contributor

@jozefrebjak jozefrebjak commented Feb 21, 2023

Description

In Adding CodeIgniter4 to an Existing Project docs is an incorrectly defined how to adjust the $systemDirectory property.

$systemDirectory should be defined as in appstarter project.

ROOTPATH constant causes an error with php spark serve like:

PHP Fatal error:  Uncaught Error: Undefined constant "Config\ROOTPATH" in /Users/jrebjak/CodeIgniter4/test-existing-project/spark:72

Stack trace:
#0 {main} thrown in /Users/jrebjak/CodeIgniter4/test-existing-project/spark on line 72

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the documentation Pull requests for documentation only label Feb 21, 2023
@samsonasik samsonasik merged commit 136b5fb into codeigniter4:develop Feb 21, 2023
@kenjis
Copy link
Member

kenjis commented Feb 21, 2023

Yes!
Config\Paths is instantiated before defining ROOTPATH.

@samsonasik
Copy link
Member

Thank you @jozefrebjak

@jozefrebjak jozefrebjak deleted the patch-1 branch February 21, 2023 10:07
@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified issues on the current code behavior or pull requests that will fix them documentation Pull requests for documentation only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants