Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Forge Class trying to create UNSIGNED fields in Postgresql #728

Closed
wants to merge 16 commits into from

Conversation

gustavojm
Copy link
Contributor

UNSIGNED is not a supported datatype in Postgre
overridden method _processColumn()

Tries to solve #719 .
Take it with a grain of salt as it's my first PR ever!

@jim-parry
Copy link
Contributor

  1. Your private application code does not belong in the CI4 repository
  2. Your private database settings do not belong either
  3. Comments (including commit messages) should be in English
  4. contributions should be GPG-signed
  5. You have added a composer dependency that doesn't work with travis-ci, by the look of it
  6. Affecting 214 files suggests that you might be inadvertently including more than you planned in your PR

Good try, but work needs to be done!
Apart from fixing the above, you will find it easier to create a feature branch for just the changes pertaining to your fixes, rather than trying to merge your entire develop branch.

@jim-parry jim-parry closed this Sep 22, 2017
@gustavojm
Copy link
Contributor Author

Jim, sorry for what happened, I initally forked a clean copy of CI4, made the changes to fix the issue, created the PR and I thought that it was it...
Then I merged another local repo I was working on previously but didn't expect it to end up in the PR.

@jim-parry
Copy link
Contributor

Oops. That's what happens when you don't do fixes in a feature branch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants