-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: New method DownloadResponse::inline() #7207
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datamweb
approved these changes
Feb 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice feat!
michalsn
approved these changes
Feb 2, 2023
kenjis
reviewed
Feb 3, 2023
kenjis
reviewed
Feb 3, 2023
kenjis
reviewed
Feb 3, 2023
Thank you. This seems good. Please update the user guide a bit. |
kenjis
reviewed
Feb 3, 2023
kenjis
approved these changes
Feb 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
kenjis
changed the title
Feature: New method DownloadResponse::inline()
feat: New method DownloadResponse::inline()
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is currently no way to change the
Content-Disposition
header when downloading a file, as this header will be overwritten when generating headers in theDownloadResponse
class.This PR prevents the
Content-Disposition
header from being changed when generating headers if that header has already been set.It also adds a
DownloadRespone::inline()
helper method that sets theContent-Disposition: inline
header.Checklist: