docs: Correcting documentation mistakes in upgrading from one version to another #7191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
str_to_upper() is not a built in php function. https://www.php.net/manual/en/function.strtoupper.php
Grammatical fix.
It says Encryption.php but the fields below are all in Email.php
kenjis
added
the
bug
kenjis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Documentation problems
https://codeigniter.com/user_guide/installation/upgrade_405.html#message-getheader-s
In the line
Request[Interface]::getMethod(): The $upper parameter will be removed, use str_to_upper()The correct PHP function is
strtoupper()https://codeigniter.com/user_guide/installation/upgrade_412.html#baseconnection-query-return-values
In the line
Review any use of query() method and be assess whether the value might be boolean instead of Result object.The word "be" does not belong in the sentence.
https://codeigniter.com/user_guide/installation/upgrade_431.html#config
Based on the description below it
app/Config/Encryption.phpshould beapp/Config/Email.phpChecklist: