Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add about removal of deprecated Config items #7173

Merged

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jan 24, 2023

Description
Supersedes #7021
See #7000 (comment)

  • update backward_compatibility_notes.rst

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • [] Conforms to style guide

@kenjis kenjis added the documentation Pull requests for documentation only label Jan 24, 2023
@samsonasik samsonasik merged commit ccab9b7 into codeigniter4:develop Feb 2, 2023
@samsonasik
Copy link
Member

Thank you @kenjis

@kenjis kenjis deleted the fix-docs-BC-note-depreacted-Config branch February 2, 2023 02:30
@kenjis
Copy link
Member Author

kenjis commented Feb 2, 2023

@lonnieezell @MGatner Are you okay with this?

@MGatner
Copy link
Member

MGatner commented Feb 2, 2023

I will defer to @lonnieezell - I'm not sure why we would ever need to remove a deprecated Config item, other than the very rare collision of things.

@kenjis
Copy link
Member Author

kenjis commented Feb 2, 2023

The reason is that there may be bugs (e.g., #4297 (comment)) that cannot be fixed, and removing them makes the code easier to read and maintain.

Copy link
Member

@lonnieezell lonnieezell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already been merged, but I don't have problems with this, I suppose.

@MGatner
Copy link
Member

MGatner commented Feb 6, 2023

I don't think that "easier to read and maintain" is enough of a reason to remove a deprecation early. Definitely in the case of bugs - we have already discussed that allowance under our practice of "Semver".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests for documentation only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants