-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cannot create shared View instance when using debugbar #7172
fix: cannot create shared View instance when using debugbar #7172
Conversation
@@ -63,7 +63,7 @@ class Events extends BaseCollector | |||
*/ | |||
public function __construct() | |||
{ | |||
$this->viewer = Services::renderer(); | |||
$this->viewer = Services::renderer(null, null, false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be clearer to use single_service('renderer')
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Using not shared service was wrong. Because the shared View has the performance data.
I will fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
A dev cannot create shared renderer instance.
fbcbfe8
to
0afa8a4
Compare
It does not return anything.
Description
(1)
DebugBar initializes shared
renderer
instance.The following code in a controller does not create a new instance with the view path.
(2)
After:
Checklist: