Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created Parser Plugin for validation errors issue#675 #716

Merged
merged 5 commits into from
Sep 15, 2017
Merged

Created Parser Plugin for validation errors issue#675 #716

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ba2af95
Update Plugins.php
jaynarayan89 Sep 10, 2017
5ec3dd5
Update View.php
jaynarayan89 Sep 10, 2017
17fa3d4
removed else from validation_errors plugin and added docs
jaynarayan89 Sep 11, 2017
e3662b1
created test for validation_errors plugin
jaynarayan89 Sep 14, 2017
6fa4cde
testing gpg keys
jaynarayan89 Sep 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions system/Config/View.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,12 @@ class View extends BaseConfig
'upper' => '\CodeIgniter\View\Filters::upper',
];
protected $corePlugins = [
'current_url' => '\CodeIgniter\View\Plugins::currentURL',
'previous_url' => '\CodeIgniter\View\Plugins::previousURL',
'current_url' => '\CodeIgniter\View\Plugins::currentURL',
'previous_url' => '\CodeIgniter\View\Plugins::previousURL',
'mailto' => '\CodeIgniter\View\Plugins::mailto',
'safe_mailto' => '\CodeIgniter\View\Plugins::safeMailto',
'safe_mailto' => '\CodeIgniter\View\Plugins::safeMailto',
'lang' => '\CodeIgniter\View\Plugins::lang',
'validation_errors' => '\CodeIgniter\View\Plugins::validationErrors',
];

public function __construct()
Expand Down
21 changes: 21 additions & 0 deletions system/View/Plugins.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,5 +121,26 @@ public static function lang(array $params = [])

return lang($line, $params);
}

/**
* @param array $params
*
* @return string
*/
public static function ValidationErrors(array $params = [])
{

$validator = \config\services::validation();
if(empty($params))
{
return $validator->listErrors();
}
else
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need else as already return early

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Please remove the else here.

{
return $validator->showError($params['field']);
}


}

}