Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [Parser] local_currency causes "Passing null to parameter" #7157

Merged
merged 3 commits into from
Jan 21, 2023
Merged

fix: [Parser] local_currency causes "Passing null to parameter" #7157

merged 3 commits into from
Jan 21, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jan 21, 2023 •
edited
Loading

Description
Fixes #7156

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

kenjis added 2 commits January 21, 2023 09:30
@kenjis
test: add test
83f026d
@kenjis
fix: Passing null to parameter error
309ec2f 
ErrorException: NumberFormatter::setAttribute(): Passing null to parameter #2 ($value) of type int|float is deprecated
@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Jan 21, 2023
@kenjis kenjis mentioned this pull request Jan 21, 2023
Closed
@kenjis kenjis merged commit 3527360 into codeigniter4:develop Jan 21, 2023
@kenjis kenjis deleted the fix-parser-local_currency branch January 21, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
2 participants
@kenjis @MGatner