Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: URI::parseStr() #7154

Merged
merged 2 commits into from
Jan 22, 2023
Merged

refactor: URI::parseStr() #7154

merged 2 commits into from
Jan 22, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jan 20, 2023

Description

  • refactor

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added the refactor Pull requests that refactor code label Jan 20, 2023
MGatner
MGatner approved these changes Jan 21, 2023
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kenjis kenjis merged commit 8743f4e into codeigniter4:develop Jan 22, 2023
@kenjis kenjis deleted the refactor-URI-parseStr branch January 22, 2023 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @MGatner