Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [QueryBuilder] RawSql passed to set() disappears without error #7148

Merged
merged 1 commit into from
Jan 20, 2023
Merged

fix: [QueryBuilder] RawSql passed to set() disappears without error #7148

merged 1 commit into from
Jan 20, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jan 18, 2023

Description
Fixes the issue #7143 (comment)

  • Throws an exception

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Jan 18, 2023
@kenjis kenjis changed the title fix: [QueryBuilder] RawSql disappear without error fix: [QueryBuilder] RawSql disappears without error Jan 18, 2023
@kenjis kenjis changed the title fix: [QueryBuilder] RawSql disappears without error fix: [QueryBuilder] RawSql passed to set() disappears without error Jan 18, 2023
@kenjis kenjis mentioned this pull request Jan 18, 2023
Closed
@kenjis kenjis added the database Issues or pull requests that affect the database layer label Jan 18, 2023
@kenjis kenjis merged commit 7be2371 into codeigniter4:develop Jan 20, 2023
@kenjis kenjis deleted the fix-Builder-set-RawSql branch January 20, 2023 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sclubricants sclubricants sclubricants approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them database Issues or pull requests that affect the database layer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @sclubricants