Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rector] Enable AddDefaultValueForUndefinedVariableRector #7088

Merged

Conversation

samsonasik
Copy link
Member

Description

AddDefaultValueForUndefinedVariableRector now already cover isset variable check, so I think it can be enabled.

Checklist:

  • Securely signed commits

@samsonasik
Copy link
Member Author

All green 🎉

@kenjis
Copy link
Member

kenjis commented Jan 12, 2023

Sorry, phpstan-baseline.neon.dist was conflicted.
Can you rebase?

@samsonasik samsonasik force-pushed the rector-enable-add-default branch from a35714c to ee9abc7 Compare January 12, 2023 10:25
@samsonasik
Copy link
Member Author

@kenjis rebased 👍

@samsonasik samsonasik merged commit 43d81fb into codeigniter4:develop Jan 12, 2023
@MGatner
Copy link
Member

MGatner commented Jan 12, 2023

Oooh this is handy!!

@samsonasik samsonasik deleted the rector-enable-add-default branch January 12, 2023 10:59
@kenjis kenjis added the refactor Pull requests that refactor code label Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Pull requests that refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants