Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert method name resetQuery() changed accidentally #7083

Merged
merged 2 commits into from
Jan 12, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jan 11, 2023

Description
From https://forum.codeigniter.com/showthread.php?tid=86096&pid=405141#pid405141

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added bug Verified issues on the current code behavior or pull requests that will fix them database Issues or pull requests that affect the database layer 4.3 labels Jan 11, 2023
@sclubricants
Copy link
Member

sclubricants commented Jan 11, 2023

This must of got mixed up with new method setQueryAsData(). Not sure how it got changed. I know we changed the name a few times and maybe I did a find and replace..

@sclubricants
Copy link
Member

Perhaps we need a test for this method? It must not have any coverage..

@kenjis
Copy link
Member Author

kenjis commented Jan 12, 2023

Added a test.

@kenjis
Copy link
Member Author

kenjis commented Jan 12, 2023

PHPStan error is not related to this PR.

Error: Ignored error pattern #^Variable \$data might not be defined\.$# in path /home/runner/work/CodeIgniter4/CodeIgniter4/system/Cache/Handlers/MemcachedHandler.php was not matched in reported errors.
 ------ ----------------------------------------------------------------------- 
  Line   system/Cache/Handlers/MemcachedHandler.php                             
 ------ ----------------------------------------------------------------------- 
         Ignored error pattern #^Variable \$data might not be defined\.$# in    
         path                                                                   
         /home/runner/work/CodeIgniter4/CodeIgniter4/system/Cache/Handlers/Mem  
         cachedHandler.php was not matched in reported errors.                  
 ------ ----------------------------------------------------------------------- 

https://github.com/codeigniter4/CodeIgniter4/actions/runs/3897874756/jobs/6656007175

@kenjis kenjis merged commit cef34b0 into codeigniter4:develop Jan 12, 2023
@kenjis kenjis deleted the fix-BaseBuilder-resetQuery branch January 12, 2023 00:40
@kenjis kenjis changed the title fix: revert method name changed accidentally fix: revert method name resetQuery() changed accidentally Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified issues on the current code behavior or pull requests that will fix them database Issues or pull requests that affect the database layer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants