Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: replace types mixed in CacheInterface and BaseHandler file. #7023

Merged
merged 3 commits into from
Dec 26, 2022
Merged

docs: replace types mixed in CacheInterface and BaseHandler file. #7023

merged 3 commits into from
Dec 26, 2022

Conversation

ping-yee
Copy link
Contributor

@ping-yee ping-yee commented Dec 25, 2022 •
edited
Loading

Description
See #6310
It seems the return types of increment and decrement functions is int or bool, so I only leave the bool|int at that two functions.
And wish you all a merry Christmas!

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

kenjis
kenjis approved these changes Dec 26, 2022
View reviewed changes
Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kenjis kenjis merged commit 958f301 into codeigniter4:develop Dec 26, 2022
@ddevsr ddevsr added the documentation Pull requests for documentation only label Jan 1, 2023
@ping-yee ping-yee deleted the docs-replace-mixed-cache-interface branch January 22, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjis kenjis kenjis approved these changes

@ddevsr ddevsr ddevsr approved these changes

@datamweb datamweb datamweb approved these changes

Assignees
No one assigned
Labels
documentation Pull requests for documentation only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ping-yee @kenjis @datamweb @ddevsr