Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add Config\Session #6989

Merged
merged 14 commits into from
Dec 20, 2022
Merged

refactor: add Config\Session #6989

merged 14 commits into from
Dec 20, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Dec 17, 2022 •
edited
Loading

Description

  • add Config\Session

Related: #4297 (comment)

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the 4.3 label Dec 17, 2022
@kenjis kenjis marked this pull request as draft December 17, 2022 10:53
@kenjis kenjis force-pushed the refactor-add-session-config branch from 47b673b to 8edd149 Compare December 17, 2022 10:57
@kenjis kenjis added the refactor Pull requests that refactor code label Dec 17, 2022
@kenjis kenjis force-pushed the refactor-add-session-config branch from 287eaa3 to 97eb3a7 Compare December 17, 2022 11:06
@kenjis kenjis added the docs needed Pull requests needing documentation write-ups and/or revisions. label Dec 17, 2022
@kenjis kenjis force-pushed the refactor-add-session-config branch 2 times, most recently from d4a8a1d to a258508 Compare December 17, 2022 12:28
@kenjis kenjis force-pushed the refactor-add-session-config branch from a258508 to 778c412 Compare December 17, 2022 12:30
@kenjis kenjis removed the docs needed Pull requests needing documentation write-ups and/or revisions. label Dec 18, 2022
@kenjis kenjis marked this pull request as ready for review December 18, 2022 01:32
MGatner
MGatner requested changes Dec 18, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't made it through all the changes to tests yet.

app/Config/Session.php Outdated Show resolved Hide resolved
system/Session/Handlers/FileHandler.php Show resolved Hide resolved
@kenjis kenjis requested a review from MGatner December 19, 2022 02:44
MGatner
MGatner approved these changes Dec 20, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kenjis! That was a big one, but something I always wanted to see happen. ❤️

@kenjis kenjis merged commit 94bd348 into codeigniter4:4.3 Dec 20, 2022
@kenjis kenjis deleted the refactor-add-session-config branch December 20, 2022 21:47
@kenjis kenjis added the enhancement PRs that improve existing functionalities label Dec 20, 2022
@kenjis kenjis mentioned this pull request Dec 21, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
4.3 enhancement PRs that improve existing functionalities refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @michalsn @MGatner