Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: BaseBuilder::getOperator() doesn't recognize LIKE operator in array expression #6986

Merged
merged 2 commits into from
Dec 20, 2022
Merged

fix: BaseBuilder::getOperator() doesn't recognize LIKE operator in array expression #6986

merged 2 commits into from
Dec 20, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Dec 17, 2022 •
edited
Loading

Description
Fixes #4347

  • no longer use getOperator() in where()

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added bug Verified issues on the current code behavior or pull requests that will fix them 4.3 labels Dec 17, 2022
@kenjis kenjis mentioned this pull request Dec 17, 2022
Closed
@kenjis kenjis added the database Issues or pull requests that affect the database layer label Dec 17, 2022
@kenjis kenjis force-pushed the fix-builder-getOperator-like branch from fe964ec to b3d965f Compare December 17, 2022 07:45
@kenjis kenjis requested a review from michalsn December 17, 2022 08:31
@kenjis kenjis merged commit d3db7d1 into codeigniter4:4.3 Dec 20, 2022
@kenjis kenjis deleted the fix-builder-getOperator-like branch December 20, 2022 21:48
@kenjis kenjis mentioned this pull request Jan 20, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
4.3 bug Verified issues on the current code behavior or pull requests that will fix them database Issues or pull requests that affect the database layer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @michalsn @MGatner