Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new make:cell command #6864

Merged
merged 5 commits into from
Nov 17, 2022
Merged

new make:cell command #6864

merged 5 commits into from
Nov 17, 2022

Conversation

lonnieezell
Copy link
Member

@lonnieezell lonnieezell commented Nov 15, 2022 •
edited by kenjis
Loading

Provides a new make:cell command to generate a controlled cell and its accompanying view.

This includes a refactor on the GeneratorTrait to split out file creation to generateClass and generateView. The first working much like the existing execute() method which has been refactored to use the generateClass method.

Ref, #6620

@lonnieezell lonnieezell changed the base branch from develop to 4.3 November 15, 2022 04:37
@kenjis kenjis added 4.3 enhancement PRs that improve existing functionalities labels Nov 15, 2022
ddevsr
ddevsr suggested changes Nov 17, 2022
View reviewed changes
Copy link
Collaborator

@ddevsr ddevsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$file is unused, can remove or using it

tests/system/Commands/CellGeneratorTest.php Outdated Show resolved Hide resolved
tests/system/Commands/CellGeneratorTest.php Outdated Show resolved Hide resolved
@lonnieezell @ddevsr
Apply suggestions from code review
323c245 
Co-authored-by: Denny Septian Panggabean <[email protected]>
@lonnieezell lonnieezell merged commit cecab92 into 4.3 Nov 17, 2022
@lonnieezell lonnieezell deleted the cell-generator branch November 17, 2022 04:53
@kenjis kenjis mentioned this pull request Nov 17, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan left review comments

@kenjis kenjis kenjis left review comments

@ddevsr ddevsr ddevsr requested changes

Assignees
No one assigned
Labels
enhancement PRs that improve existing functionalities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lonnieezell @kenjis @paulbalandan @ddevsr