Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: make time() to class Time in Cache #6850

Merged
merged 3 commits into from
Nov 14, 2022
Merged

refactor: make time() to class Time in Cache #6850

merged 3 commits into from
Nov 14, 2022

Conversation

ddevsr
Copy link
Collaborator

@ddevsr ddevsr commented Nov 13, 2022

Description
See #6815

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@ddevsr ddevsr changed the title refactor: make time() to class Time refactor: make time() to class Time in Cache Nov 13, 2022
@ddevsr ddevsr marked this pull request as ready for review November 13, 2022 13:45
@ddevsr ddevsr added the refactor Pull requests that refactor code label Nov 13, 2022
MGatner
MGatner approved these changes Nov 14, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for taking this on. I think the "assert less than" calls could be controlled now with a fixed test time, but probably not necessary for the scope.

@MGatner MGatner merged commit 49aeab2 into codeigniter4:develop Nov 14, 2022
@ddevsr ddevsr deleted the cache-time-class branch November 14, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

@kenjis kenjis kenjis approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ddevsr @kenjis @MGatner