Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace time() with Time in Session.php #6847

Merged
merged 2 commits into from
Nov 14, 2022
Merged

refactor: replace time() with Time in Session.php #6847

merged 2 commits into from
Nov 14, 2022

Conversation

ping-yee
Copy link
Contributor

Description
See #6815

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the refactor Pull requests that refactor code label Nov 13, 2022
@ping-yee
Copy link
Contributor Author

Error: CodeIgniter\Session\Session must not depend on CodeIgniter\I18n\Time (Session on I18n)

@kenjis I have no idea how to fix this, can you give some suggestions for me?

@kenjis
Copy link
Member

kenjis commented Nov 13, 2022 

--- a/deptrac.yaml
+++ b/deptrac.yaml
@@ -201,6 +201,7 @@ parameters:
       - Cookie
       - HTTP
       - Database
+      - I18n
     Throttle:
       - Cache
     Validation:

See https://qossmic.github.io/deptrac/

MGatner
MGatner reviewed Nov 13, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I like that with these changes Deptrac will be able to report on our explicitly system clock usage.

@ping-yee
Copy link
Contributor Author

Appricated that!
I've been added that.

MGatner
MGatner approved these changes Nov 14, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MGatner MGatner merged commit 11bb96b into codeigniter4:develop Nov 14, 2022
@ping-yee ping-yee deleted the refactor-replace-time-in-session branch April 25, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

@datamweb datamweb datamweb approved these changes

@samsonasik samsonasik samsonasik approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ping-yee @kenjis @samsonasik @datamweb @MGatner