Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix @param types in html/url helper #6767

Merged
merged 2 commits into from
Oct 27, 2022
Merged

docs: fix @param types in html/url helper #6767

merged 2 commits into from
Oct 27, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Oct 27, 2022 •
edited
Loading

Description
See #6310

  • fix @param types

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis force-pushed the fix-phpdocs-html-url-helper branch from 007dd44 to 31d5843 Compare October 27, 2022 06:42
MGatner
MGatner approved these changes Oct 27, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not going to confirm all the types. If PHPStan and Psalm are happy with these and you feel confident in them then they is good enough for me.

@kenjis kenjis merged commit a01d2dd into codeigniter4:develop Oct 27, 2022
@kenjis kenjis deleted the fix-phpdocs-html-url-helper branch October 27, 2022 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @MGatner