Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove unneeded code in form_helper #6721

Merged
merged 2 commits into from
Oct 20, 2022
Merged

refactor: remove unneeded code in form_helper #6721

merged 2 commits into from
Oct 20, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Oct 20, 2022 •
edited
Loading

Description

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

kenjis added 2 commits October 20, 2022 08:47
@kenjis
docs: fix PHPDoc types
3a3afd4
@kenjis
refactor: remove unneeded elseif
0df554b 
$defaults['checked'] always does not exists.
@kenjis kenjis added the refactor Pull requests that refactor code label Oct 20, 2022
@kenjis kenjis mentioned this pull request Oct 20, 2022
Closed
5 tasks
@kenjis kenjis merged commit 18206b1 into codeigniter4:develop Oct 20, 2022
@kenjis kenjis deleted the fix-phpdocs-form_helper branch October 20, 2022 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

@datamweb datamweb datamweb approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @datamweb @paulbalandan