Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix PHPDoc type mixed #6715

Merged
merged 13 commits into from
Oct 20, 2022
Merged

docs: fix PHPDoc type mixed #6715

merged 13 commits into from
Oct 20, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Oct 19, 2022 •
edited
Loading

Needs #6722

Description
See #6310

  • fix PHPDoc types
  • remove unneeded empty check

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

MGatner
MGatner requested changes Oct 19, 2022
View reviewed changes
system/BaseModel.php Outdated Show resolved Hide resolved
system/Common.php Outdated Show resolved Hide resolved
@ddevsr ddevsr mentioned this pull request Oct 19, 2022
Closed
5 tasks
@kenjis kenjis requested a review from MGatner October 19, 2022 23:22
@kenjis kenjis added the refactor Pull requests that refactor code label Oct 19, 2022
samsonasik
samsonasik reviewed Oct 20, 2022
View reviewed changes
system/Common.php Outdated Show resolved Hide resolved
@kenjis kenjis marked this pull request as draft October 20, 2022 01:47
@kenjis kenjis mentioned this pull request Oct 20, 2022
Merged
3 tasks
@kenjis kenjis removed the refactor Pull requests that refactor code label Oct 20, 2022
@kenjis kenjis marked this pull request as ready for review October 20, 2022 07:44
@kenjis kenjis merged commit 1571861 into codeigniter4:develop Oct 20, 2022
@kenjis kenjis deleted the fix-phpdoc-mixed branch October 20, 2022 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonasik samsonasik samsonasik left review comments

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @samsonasik @MGatner