Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Opt-in logging of deprecations #6705

Merged
merged 4 commits into from
Oct 22, 2022
Merged

feat: Opt-in logging of deprecations #6705

merged 4 commits into from
Oct 22, 2022

Conversation

paulbalandan
Copy link
Member

@paulbalandan paulbalandan commented Oct 17, 2022 •
edited
Loading

Description
Depends on #6704
Alternative to #6703

Opt-in feature to log deprecations (both internal and user-supplied) instead of thrown by the error handler.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan paulbalandan added docs needed Pull requests needing documentation write-ups and/or revisions. 4.3 labels Oct 17, 2022
@kenjis kenjis added the enhancement PRs that improve existing functionalities label Oct 17, 2022
@najdanovicivan najdanovicivan mentioned this pull request Oct 17, 2022
Closed
5 tasks
@paulbalandan paulbalandan force-pushed the deprecations-log branch 2 times, most recently from 7e655b7 to 4700939 Compare October 17, 2022 13:20
MGatner
MGatner requested changes Oct 18, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm haven't looked at test, waiting on rebase. Overall looks good! I think you're right: this will become a much more appealing feature for users once 7.4 drops and 8.1 and 8.2 surge.

app/Config/Exceptions.php Outdated Show resolved Hide resolved
system/Debug/Exceptions.php Outdated Show resolved Hide resolved
system/Debug/Exceptions.php Outdated Show resolved Hide resolved
system/Debug/Exceptions.php Show resolved Hide resolved
@paulbalandan paulbalandan added the stale Pull requests with conflicts label Oct 20, 2022
@paulbalandan paulbalandan removed the stale Pull requests with conflicts label Oct 20, 2022
MGatner
MGatner reviewed Oct 20, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! A couple of thoughts still there, but I'm good with this if we need to launch at any point.

tests/system/Debug/ExceptionsTest.php Show resolved Hide resolved
@paulbalandan paulbalandan removed the docs needed Pull requests needing documentation write-ups and/or revisions. label Oct 21, 2022
MGatner
MGatner approved these changes Oct 21, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@paulbalandan paulbalandan requested a review from kenjis October 21, 2022 13:45
@paulbalandan paulbalandan merged commit a4d3201 into codeigniter4:4.3 Oct 22, 2022
@paulbalandan paulbalandan deleted the deprecations-log branch October 22, 2022 04:21
This was referenced Oct 28, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonasik samsonasik samsonasik left review comments

@MGatner MGatner MGatner approved these changes

@kenjis kenjis kenjis approved these changes

Assignees
No one assigned
Labels
enhancement PRs that improve existing functionalities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paulbalandan @kenjis @samsonasik @MGatner