fix: support for assigning extra data for the view() method in controlled cells #6681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalsn
added
bug
MGatner
reviewed
Oct 14, 2022
There was a problem hiding this comment.
Love the Lost reference 😍
This looks good and logical to me. Let's see if @lonnieezell is around to confirm his intention.
|
🤦♂️ Always read the comments first. I'm so bad at it! |
kenjis
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up #6620
This is related to the Controlled Cells.
According to the user guide, we should be able to assign extra variables to the
view()method. But this function doesn't seem to be implemented. This PR fixes it.Ref: https://github.com/codeigniter4/CodeIgniter4/blob/4.3/user_guide_src/source/outgoing/view_cells.rst#customize-the-rendering
Checklist: