Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the user guide of the insert() method to include the second parameter #6660

Merged
merged 4 commits into from
Oct 17, 2022

Conversation

tbobker123
Copy link
Contributor

@tbobker123 tbobker123 commented Oct 10, 2022

Description
The insert method takes 2 paraemtres, but only 1 parametre has been detailed. Furthermore, the description currently details using the getInsertID() to get the rows insert id, but this is already the default return value, so it doesn't make sense to add this to the description.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the documentation Pull requests for documentation only label Oct 10, 2022
@kenjis kenjis added the GPG-Signing needed Pull requests that need GPG-Signing label Oct 10, 2022
@kenjis
Copy link
Member

kenjis commented Oct 10, 2022

Thank you for sending the PR!

You forgot the signing to your commits.
See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#signing

@tbobker123
Copy link
Contributor Author

Commits not getting verified. Need to fix that.

user_guide_src/source/models/model.rst Outdated Show resolved Hide resolved
user_guide_src/source/models/model/015.php Outdated Show resolved Hide resolved
user_guide_src/source/models/model.rst Show resolved Hide resolved
@tbobker123
Copy link
Contributor Author

The suggestions were perfect. Thank you.

Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The contents seem good!

Please squash the commits, and sign.
Because there are some commits without signing.

@tbobker123 tbobker123 force-pushed the modify-insert-method-details branch from b61c8de to 79e177f Compare October 13, 2022 16:18
@tbobker123
Copy link
Contributor Author

Its possible my squash / commit went wrong!

@tbobker123
Copy link
Contributor Author

Yep, it squashed into the wrong commit. I'll do it again.

@kenjis kenjis removed the GPG-Signing needed Pull requests that need GPG-Signing label Oct 13, 2022
@kenjis kenjis merged commit 62c560b into codeigniter4:develop Oct 17, 2022
@kenjis
Copy link
Member

kenjis commented Oct 17, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests for documentation only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants