-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify the user guide of the insert() method to include the second parameter #6660
Modify the user guide of the insert() method to include the second parameter #6660
Conversation
Thank you for sending the PR! You forgot the signing to your commits. |
Commits not getting verified. Need to fix that. |
The suggestions were perfect. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The contents seem good!
Please squash the commits, and sign.
Because there are some commits without signing.
b61c8de
to
79e177f
Compare
Its possible my squash / commit went wrong! |
Yep, it squashed into the wrong commit. I'll do it again. |
Thank you! |
Description
The insert method takes 2 paraemtres, but only 1 parametre has been detailed. Furthermore, the description currently details using the getInsertID() to get the rows insert id, but this is already the default return value, so it doesn't make sense to add this to the description.
Checklist: