Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move print_r to interpolate and use clean_path #6654

Merged
merged 1 commit into from
Oct 11, 2022
Merged

refactor: move print_r to interpolate and use clean_path #6654

merged 1 commit into from
Oct 11, 2022

Conversation

ddevsr
Copy link
Collaborator

@ddevsr ddevsr commented Oct 10, 2022

Description
Follow-up #6638

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the refactor Pull requests that refactor code label Oct 10, 2022
MGatner
MGatner approved these changes Oct 10, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samsonasik samsonasik merged commit 44c767c into codeigniter4:develop Oct 11, 2022
@samsonasik
Copy link
Member

Thank you @ddevsr

@ddevsr ddevsr deleted the refactor-logger branch October 11, 2022 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

@samsonasik samsonasik samsonasik approved these changes

@kenjis kenjis kenjis approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ddevsr @samsonasik @kenjis @MGatner