Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add method to disable controller filters #6652

Merged
merged 3 commits into from
Oct 14, 2022
Merged

feat: add method to disable controller filters #6652

merged 3 commits into from
Oct 14, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Oct 9, 2022

Description

  • add method to disable controller filters

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added enhancement PRs that improve existing functionalities 4.3 labels Oct 9, 2022
MGatner
MGatner approved these changes Oct 10, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An interesting feature. What do you recommend this for? Troubleshooting?

@kenjis
Copy link
Member Author

kenjis commented Oct 11, 2022

I would like to make an internal sub request.
That is, creating another request in a controller like this:
https://github.com/ivanvoitovych/viewi-symfony-demo/blob/5c944f1c919efacc045c633d659e415bccd6e721/src/Adapters/ViewiSymfonyAdapter.php#L25-L27

Another use case I imagine is, when using CLI controllers and no filters are needed.

@kenjis kenjis merged commit cca6295 into codeigniter4:4.3 Oct 14, 2022
@kenjis kenjis deleted the feat-disable-filters branch October 14, 2022 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
enhancement PRs that improve existing functionalities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @MGatner