-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: replace types mixed
at all classes in Validation
.
#6607
docs: replace types mixed
at all classes in Validation
.
#6607
Conversation
mixed
at all of Validation
class.mixed
at all classes in Validation
.
Probably the input value type is |
Honestly, I am not sure about the different between normal rule and strict rule. Is it just different between having strict mode and not having strict mode? Like:
CodeIgniter4/system/Validation/Rules.php Line 27 in dbb3426
CodeIgniter4/system/Validation/Rules.php Line 39 in dbb3426
If all of the values need to be changed to |
See https://codeigniter4.github.io/CodeIgniter4/libraries/validation.html#traditional-and-strict-rules Traditional Rules are legacy. These are not designed to validate non-string values. Strictly speaking, probably traditional rule parameter types should be removed, too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm afraid it will need to be more nuanced and painstaking than this. For example, the first line of int
:
if (is_int($str)) {
... clearly means to support int
input.
I think it is a problem with our Validation class in a larger scale, that it is trying to be both Form Validation and more General/Persistence Validation. But until a rework is agreed upon and executed we will need to try to hold these together.
Yeah, it looks like will be a huge work and what I think is too easy before. |
Description
See #6310
I don't modify the
mixed
atreuquired_without[]
comment out inValidation\StrictRules\Rules.php
because I already changed it at PR #6589 .Checklist: