Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove dynamic properties #6587

Merged
merged 5 commits into from
Sep 26, 2022
Merged

test: remove dynamic properties #6587

merged 5 commits into from
Sep 26, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Sep 25, 2022

Description
See #6170

  • remove dynamic properties

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis
test: remove dynamic property in ControllerTest
f788d46
@kenjis
test: remove dynamic property in FactoriesTest
c9ff6b1
@kenjis
test: add missing property in TestHandler
da4040a 
ErrorException: Creation of dynamic property Tests\Support\Log\Handlers\TestHandler::$destination is deprecated
@kenjis kenjis added the testing Pull requests that changes tests only label Sep 25, 2022
@kenjis kenjis mentioned this pull request Sep 25, 2022
Closed
7 tasks
MGatner
MGatner reviewed Sep 25, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would anonymous class extension injection be better than fixtures? These don't seem to have much reuse value.

@kenjis
Copy link
Member Author

kenjis commented Sep 26, 2022

Would anonymous class extension injection be better than fixtures? These don't seem to have much reuse value.

Yes! Fixed.

MGatner
MGatner approved these changes Sep 26, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks great.

@kenjis kenjis merged commit c3e2582 into codeigniter4:develop Sep 26, 2022
@kenjis kenjis deleted the fix-test-dynamic-properties branch September 26, 2022 22:21
@kenjis kenjis added the PHP 8.2 label Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
testing Pull requests that changes tests only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @MGatner @paulbalandan