Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ResponseInterface (1) #6556

Merged
merged 8 commits into from
Sep 23, 2022
Merged

fix: ResponseInterface (1) #6556

merged 8 commits into from
Sep 23, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Sep 20, 2022 •
edited
Loading

Description
Ref #4356
Fixes #5351

  • fix ResponseInterface
  • fix MessageInterface
  • deprecate
    • CodeIgniter::$useSafeOutput
    • CodeIgniter::useSafeOutput()

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added bug Verified issues on the current code behavior or pull requests that will fix them breaking change Pull requests that may break existing functionalities 4.3 labels Sep 20, 2022
MGatner
MGatner requested changes Sep 21, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better separation of concerns! A few suggestions.

system/CodeIgniter.php Show resolved Hide resolved
system/HTTP/Response.php Show resolved Hide resolved
@kenjis kenjis force-pushed the fix-ResponseInterface branch from 9e0375e to 4cff965 Compare September 22, 2022 23:31
@kenjis kenjis marked this pull request as draft September 22, 2022 23:31
@kenjis kenjis added the docs needed Pull requests needing documentation write-ups and/or revisions. label Sep 22, 2022
@kenjis
docs: add changelog and upgrade
3dab2de
@kenjis
docs: fix reference name
9fbd5f8 
We use a dash as a separator, not a underscore.
@kenjis
Copy link
Member Author

kenjis commented Sep 23, 2022

Added the docs.

I've found this PR is not enough to fix ResponseInterface.
But it seems a lot of changes will be needed, so I'm going to another PR.

@kenjis kenjis removed the docs needed Pull requests needing documentation write-ups and/or revisions. label Sep 23, 2022
@kenjis kenjis changed the title fix: ResponseInterface fix: ResponseInterface (1) Sep 23, 2022
@kenjis kenjis marked this pull request as ready for review September 23, 2022 01:23
@kenjis kenjis mentioned this pull request Sep 23, 2022
Merged
5 tasks
MGatner
MGatner approved these changes Sep 23, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs look good

@kenjis kenjis merged commit a7d5d26 into codeigniter4:4.3 Sep 23, 2022
@kenjis kenjis deleted the fix-ResponseInterface branch September 23, 2022 23:30
@MGatner MGatner mentioned this pull request Oct 15, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
4.3 breaking change Pull requests that may break existing functionalities bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @MGatner