Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: replace types in View\Parser and View\Filters #6550

Merged
merged 9 commits into from
Sep 22, 2022
Merged

docs: replace types in View\Parser and View\Filters #6550

merged 9 commits into from
Sep 22, 2022

Conversation

ddevsr
Copy link
Collaborator

@ddevsr ddevsr commented Sep 17, 2022 •
edited by kenjis
Loading

Description
See #6310

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

paulbalandan
paulbalandan reviewed Sep 17, 2022
View reviewed changes
system/View/Filters.php Outdated Show resolved Hide resolved
system/View/Parser.php Outdated Show resolved Hide resolved
@kenjis kenjis changed the title docs: replace doctype View\Parser and View\Filters docs: replace types in View\Parser and View\Filters Sep 17, 2022
kenjis
kenjis reviewed Sep 17, 2022
View reviewed changes
system/View/Parser.php Outdated Show resolved Hide resolved
MGatner
MGatner requested changes Sep 18, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good changes! A few issues that need attention. The last one (objectToArray()) will be hard for me to look into on mobile, so please let me know if you have already examined the uses or I will dig later on desktop.

system/View/Filters.php Outdated Show resolved Hide resolved
system/View/Filters.php Outdated Show resolved Hide resolved
system/View/Parser.php Outdated Show resolved Hide resolved
@ddevsr ddevsr mentioned this pull request Sep 19, 2022
Closed
@ddevsr ddevsr requested a review from MGatner September 20, 2022 06:52
kenjis
kenjis reviewed Sep 20, 2022
View reviewed changes
system/View/Parser.php Outdated Show resolved Hide resolved
kenjis
kenjis reviewed Sep 20, 2022
View reviewed changes
system/View/Parser.php Outdated Show resolved Hide resolved
kenjis
kenjis approved these changes Sep 22, 2022
View reviewed changes
Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

MGatner
MGatner approved these changes Sep 22, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me too! Thanks for this attention, and the work to get it ready 👌

@MGatner MGatner merged commit b65156e into codeigniter4:develop Sep 22, 2022
@ddevsr ddevsr deleted the fix-doctype-parser-filters branch September 22, 2022 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan left review comments

@MGatner MGatner MGatner approved these changes

@kenjis kenjis kenjis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ddevsr @kenjis @MGatner @paulbalandan