Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: replace PHPDoc mixed in view table #6547

Merged
merged 2 commits into from
Sep 17, 2022
Merged

docs: replace PHPDoc mixed in view table #6547

merged 2 commits into from
Sep 17, 2022

Conversation

ddevsr
Copy link
Collaborator

@ddevsr ddevsr commented Sep 17, 2022

Description
See #6310

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kenjis
Copy link
Member

kenjis commented Sep 17, 2022

This might be outside the scope of the PR, but what does this comment say?

* Can be passed as an array or discreet params

Just a copy and paste mistake?
"Can be passed as an array or discreet params" is also found in setHeading() and setFooting().

@ddevsr
Copy link
Collaborator Author

ddevsr commented Sep 17, 2022

This might be outside the scope of the PR, but what does this comment say?

* Can be passed as an array or discreet params

Based variable property type on $emptyCells

/**
* Contents of empty cells
*
* @var string
*/
public $emptyCells = '';

In TableTest all setEmpty function using string. I think better remove comment Can be passed as an array or discreet params in setEmpty

Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@MGatner MGatner merged commit 591f90b into codeigniter4:develop Sep 17, 2022
@ddevsr ddevsr deleted the fix-doctype-table branch September 17, 2022 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants