Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added about signing gpg to old commit #6497

Merged
merged 2 commits into from
Sep 6, 2022
Merged

docs: added about signing gpg to old commit #6497

merged 2 commits into from
Sep 6, 2022

Conversation

ddevsr
Copy link
Collaborator

@ddevsr ddevsr commented Sep 5, 2022

Description
Adding how to signing gpg to old commit.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis
Copy link
Member

kenjis commented Sep 5, 2022

Thank you.

By the way, is there anyone who uses git commit -S option in real life?
I've never used the option.

@ddevsr
Copy link
Collaborator Author

ddevsr commented Sep 5, 2022

Thank you.

By the way, is there anyone who uses git commit -S option in real life? I've never used the option.

@kenjis Yes, -S will be not used if git config --global commit.gpgsign true and git config --global user.signingkey 3AC5C34371567BD2 already set. According to what I have given a note regarding this PR. I before never use too on my old repos, and recently applied in repo community based.

@kenjis kenjis merged commit 8d6584d into codeigniter4:develop Sep 6, 2022
@ddevsr ddevsr deleted the gpg-old-commit branch September 6, 2022 04:46
@paulbalandan paulbalandan mentioned this pull request Sep 6, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants