Fix for issue #642 regarding the route_to function and post routes #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 2, 2017 16:56
…\Config\Paths() This allows for changing of Path variables based on the environment when running tests.
…with routes other then post
|
Looks pretty good. The only thing I see immediately, is just that some additional tests for route matching may be in order, especially where different methods have the same $from but use different controller values. |
|
@daylightstudio will you be able to add the additional tests for this? |
|
Excellent. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following pull request changes the RouteCollection class to allow for the route_to function to work on routes other then
getrequests. The fix was to add an additional nested key to the$routesarray for the HTTPVerb (e.g.$this->routes['post']['my_route']). For those routes without a verb specified, a wild card "*" is used.A single test was added to check that the reverseRoutes method works with a post route which is what the route_to function is a wrapper around.