Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken caching system when array of allowed parameters used #6475

Merged
merged 2 commits into from
Sep 4, 2022
Merged

Fix broken caching system when array of allowed parameters used #6475

merged 2 commits into from
Sep 4, 2022

Conversation

JavaDeveloperKiev
Copy link
Contributor

@JavaDeveloperKiev JavaDeveloperKiev commented Sep 2, 2022 •
edited by kenjis
Loading

New clean PR of #6410 after rebase

Discussion available here:
#6410

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@JavaDeveloperKiev JavaDeveloperKiev mentioned this pull request Sep 2, 2022
Closed
5 tasks
@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Sep 2, 2022
@JavaDeveloperKiev
Copy link
Contributor Author

@kenjis can you please explain details or share link where I can read about coveralls, and why the test is failing. Did I do something wrong?

Thanks!

@kenjis
Copy link
Member

kenjis commented Sep 2, 2022

Did I do something wrong?

No. I don't know why but coveralls reports Coverage decreased often.

@JavaDeveloperKiev
Copy link
Contributor Author

Did I do something wrong?

No. I don't know why but coveralls reports Coverage decreased often.

Okay, then I believe thats it :)

Let me know if I have to do some other fixes/changes

@ddevsr
Copy link
Collaborator

ddevsr commented Sep 2, 2022

@JavaDeveloperKiev In report website, your PR increase coverage

https://coveralls.io/builds/52168240/source?filename=system%2FCodeIgniter.php

@kenjis kenjis changed the title Caching bug fix Fix broken caching system when array of allowed parameters used Sep 2, 2022
MGatner
MGatner approved these changes Sep 3, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice PR! I'm sure we could clear the cache directly, but the use of stream filters and command() is very creative 😊

@kenjis kenjis merged commit a8072a5 into codeigniter4:develop Sep 4, 2022
@kenjis
Copy link
Member

kenjis commented Sep 4, 2022

Thank you!

@kenjis kenjis mentioned this pull request Sep 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

@kenjis kenjis kenjis approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JavaDeveloperKiev @kenjis @ddevsr @MGatner