Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: replace mixed in Database doc comments #6424

Merged
merged 1 commit into from
Aug 27, 2022
Merged

docs: replace mixed in Database doc comments #6424

merged 1 commit into from
Aug 27, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Aug 26, 2022

Description
Ref #6310

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

MGatner
MGatner approved these changes Aug 27, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not going to dig through the code on mobile to verify each of these. If you are confident in the types then proceed; if you'd like to wait for a proper review I can do it later on desktop, just re-request.

@kenjis kenjis merged commit 0d90f84 into codeigniter4:develop Aug 27, 2022
@kenjis kenjis deleted the remove-mixed-in-db branch August 27, 2022 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @MGatner