Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group list route based on handler #6415

Closed

Conversation

agungsugiarto
Copy link
Contributor

@agungsugiarto agungsugiarto commented Aug 23, 2022

Each pull request should address a single issue and have a meaningful title.

  • All bug fixes should be sent to the "develop" branch, this is where the next bug fix version will be developed.
  • PRs with any enhancement should be sent to the next minor version branch, e.g. "4.3"

Description
Group list route based on handler controller, output look like this:
image

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the breaking change Pull requests that may break existing functionalities label Aug 23, 2022
@kenjis
Copy link
Member

kenjis commented Aug 23, 2022

Thank you for sending a PR.

  1. Why do you need this?
  2. If this is not a bug fix, you should sent a PR to 4.3 branch

@kenjis kenjis added the tests needed Pull requests that need tests label Aug 23, 2022
@kenjis kenjis added wrong branch PRs sent to wrong branch docs needed Pull requests needing documentation write-ups and/or revisions. waiting for info Issues or pull requests that need further clarification from the author labels Oct 17, 2022
@kenjis
Copy link
Member

kenjis commented Oct 17, 2022

I think this should be an option for the spark routes command.

@kenjis kenjis added needs rework Changes requested by reviewer that are still pending GPG-Signing needed Pull requests that need GPG-Signing labels Oct 17, 2022
@kenjis
Copy link
Member

kenjis commented Jan 7, 2023

Closed by #7015

@kenjis kenjis closed this Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Pull requests that may break existing functionalities docs needed Pull requests needing documentation write-ups and/or revisions. GPG-Signing needed Pull requests that need GPG-Signing needs rework Changes requested by reviewer that are still pending tests needed Pull requests that need tests waiting for info Issues or pull requests that need further clarification from the author wrong branch PRs sent to wrong branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants