Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add param $withSessionErrors to Validation::getErrors() #6381

Closed
wants to merge 3 commits into from
Closed

feat: add param $withSessionErrors to Validation::getErrors() #6381

wants to merge 3 commits into from

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Aug 16, 2022 •
edited
Loading

Description
See #6380

  • add a parameter to exclude validation errors in the session

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added enhancement PRs that improve existing functionalities 4.3 breaking change Pull requests that may break existing functionalities labels Aug 16, 2022
@kenjis kenjis force-pushed the feat-Validation-getErrors-param-withSessionErrors branch from 40a4aa2 to 91ba73d Compare August 16, 2022 02:17
@kenjis kenjis mentioned this pull request Aug 16, 2022
Merged
@kenjis kenjis force-pushed the feat-Validation-getErrors-param-withSessionErrors branch from 91ba73d to 7fbaa7d Compare August 16, 2022 22:52
@kenjis
Copy link
Member Author

kenjis commented Aug 16, 2022

Rebased and added the changelog.

@kenjis kenjis mentioned this pull request Aug 17, 2022
Merged
5 tasks
@kenjis kenjis marked this pull request as draft August 17, 2022 04:36
@kenjis
Copy link
Member Author

kenjis commented Aug 17, 2022

I sent a PR with a different approach. See #6384

@kenjis
Copy link
Member Author

kenjis commented Aug 19, 2022

We proceed #6384

@kenjis kenjis closed this Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
4.3 breaking change Pull requests that may break existing functionalities enhancement PRs that improve existing functionalities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @MGatner